fix(mentor): unbreak the mentor pipeline end-to-end

Adding the MENTOR role from /admin/members/[id] only updated React state — the
AlertDialog "Add role" confirmation never called the server, so prod ended up
with zero users in MENTOR roles[] and /admin/mentors showed "No mentors yet".
The dialog now awaits updateUser.mutateAsync({ roles }) before closing.

Other corrections in the same area:

- DialogContent uses flex flex-col with max-h-[90vh] overflow-y-auto so tall
  modals (e.g. Add Project to Round) scroll internally instead of overflowing
  past their own rounded background.
- getProjectsNeedingMentor now matches autoAssignBulkForRound exactly: both
  filter mentorAssignments by droppedAt: null and require
  finalistConfirmation: CONFIRMED, so the toolbar count never exceeds what
  auto-fill actually processes. The toolbar surfaces hasNoMentors /
  hasNoEligible / count / all-assigned as distinct states instead of one
  misleading "All eligible projects have a mentor" line.
- New per-team table (MentoringProjectsTable) replaces ProjectStatesTable on
  the Projects tab of MENTORING rounds. Lists every project with its active
  mentors (multi-mentor aware), filter pills, search, finalist-confirmation
  badge, and a per-row link to /admin/projects/[id]/mentor for assigning.
- Applicant team page now lists ALL active mentors (PR8 Task 7) instead of
  just mentorAssignments[0].
- Hard guard in src/lib/email.ts short-circuits sendEmail when NODE_ENV=test
  or VITEST=true so test runs can never emit real notifications again.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

src/app/(admin)/admin/members/[id]/page.tsx

@@ -976,17 +976,39 @@ export default function MemberDetailPage() {
               Cancel
             </AlertDialogCancel>
             <AlertDialogAction
-              onClick={() => {
+              onClick={async () => {
                 if (!pendingAdditionalRole) return
                 const { role: r, action } = pendingAdditionalRole
-                if (action === 'add') {
-                  setAdditionalRoles((prev) =>
-                    prev.includes(r) ? prev : [...prev, r]
+                const nextAdditional =
+                  action === 'add'
+                    ? additionalRoles.includes(r)
+                      ? additionalRoles
+                      : [...additionalRoles, r]
+                    : additionalRoles.filter((x) => x !== r)
+                const nextAllRoles = [
+                  role,
+                  ...nextAdditional.filter((x) => x !== role),
+                ] as Array<'SUPER_ADMIN' | 'PROGRAM_ADMIN' | 'JURY_MEMBER' | 'MENTOR' | 'OBSERVER' | 'APPLICANT' | 'AUDIENCE'>
+                try {
+                  await updateUser.mutateAsync({
+                    id: userId,
+                    roles: nextAllRoles,
+                  })
+                  setAdditionalRoles(nextAdditional)
+                  utils.user.get.invalidate({ id: userId })
+                  utils.user.list.invalidate()
+                  toast.success(
+                    action === 'add'
+                      ? `${r.replace(/_/g, ' ')} role added`
+                      : `${r.replace(/_/g, ' ')} role removed`,
                   )
-                } else {
-                  setAdditionalRoles((prev) => prev.filter((x) => x !== r))
+                } catch (error) {
+                  toast.error(
+                    error instanceof Error ? error.message : 'Failed to update roles',
+                  )
+                } finally {
+                  setPendingAdditionalRole(null)
                 }
-                setPendingAdditionalRole(null)
               }}
             >
               {pendingAdditionalRole?.action === 'add' ? 'Add role' : 'Remove role'}

src/app/(admin)/admin/rounds/[roundId]/page.tsx

@@ -92,6 +92,7 @@ import { ProjectStatesTable } from '@/components/admin/round/project-states-tabl
 import { FileRequirementsEditor } from '@/components/admin/round/file-requirements-editor'
 import { FilteringDashboard } from '@/components/admin/round/filtering-dashboard'
 import { MentoringRoundOverview } from '@/components/admin/round/mentoring-round-overview'
+import { MentoringProjectsTable } from '@/components/admin/round/mentoring-projects-table'
 import { FinalistSlotsCard } from '@/components/admin/grand-finale/finalist-slots-card'
 import { WaitlistCard } from '@/components/admin/grand-finale/waitlist-card'
 import { RankingDashboard } from '@/components/admin/round/ranking-dashboard'
@@ -168,6 +169,10 @@ function MentoringBulkAssignToolbar({
     { enabled: !isAdminSelected, refetchInterval: 30_000 },
   )
   const count = pending?.count ?? 0
+  const eligibleTotal = pending?.eligibleTotal ?? 0
+  const mentorPoolSize = pending?.mentorPoolSize ?? 0
+  const hasNoMentors = mentorPoolSize === 0
+  const hasNoEligible = eligibleTotal === 0
 
   const bulk = trpc.mentor.autoAssignBulkForRound.useMutation({
     onSuccess: (result) => {
@@ -190,23 +195,41 @@ function MentoringBulkAssignToolbar({
               — auto-fill is disabled. Assign each project manually.
             </span>
           </>
+        ) : hasNoMentors ? (
+          <span className="text-muted-foreground">
+            No mentors in the pool yet —{' '}
+            <Link
+              href="/admin/members?tab=mentors"
+              className="text-foreground underline-offset-2 hover:underline"
+            >
+              add mentors
+            </Link>{' '}
+            before auto-filling.
+          </span>
+        ) : hasNoEligible ? (
+          <span className="text-muted-foreground">
+            No projects are eligible for mentorship in this round (
+            {eligibilityLabel}).
+          </span>
         ) : count > 0 ? (
           <>
             <span className="font-medium">{count}</span>{' '}
             <span className="text-muted-foreground">
-              project{count === 1 ? '' : 's'} eligible for auto-fill ({eligibilityLabel})
+              of {eligibleTotal} project{eligibleTotal === 1 ? '' : 's'} still
+              needs a mentor ({eligibilityLabel})
             </span>
           </>
         ) : (
           <span className="text-muted-foreground">
-            All eligible projects have a mentor.
+            All {eligibleTotal} eligible project{eligibleTotal === 1 ? '' : 's'}{' '}
+            already have a mentor.
           </span>
         )}
       </div>
       <Button
         size="sm"
         onClick={() => bulk.mutate({ roundId })}
-        disabled={isAdminSelected || count === 0 || bulk.isPending}
+        disabled={isAdminSelected || count === 0 || hasNoMentors || bulk.isPending}
       >
         {bulk.isPending ? <Loader2 className="mr-2 h-4 w-4 animate-spin" /> : null}
         Auto-fill remaining
@@ -1570,19 +1593,24 @@ export default function RoundDetailPage() {
         {/* ═══════════ PROJECTS TAB ═══════════ */}
         <TabsContent value="projects" className="space-y-4">
           {isMentoring && (
-            <MentoringBulkAssignToolbar roundId={roundId} configJson={config} />
+            <>
+              <MentoringBulkAssignToolbar roundId={roundId} configJson={config} />
+              <MentoringProjectsTable roundId={roundId} />
+            </>
+          )}
+          {!isMentoring && (
+            <ProjectStatesTable
+              competitionId={competitionId}
+              roundId={roundId}
+              roundStatus={round?.status}
+              competitionRounds={competition?.rounds}
+              currentSortOrder={round?.sortOrder}
+              onAssignProjects={() => {
+                setActiveTab('assignments')
+                setTimeout(() => setPreviewSheetOpen(true), 100)
+              }}
+            />
           )}
-          <ProjectStatesTable
-            competitionId={competitionId}
-            roundId={roundId}
-            roundStatus={round?.status}
-            competitionRounds={competition?.rounds}
-            currentSortOrder={round?.sortOrder}
-            onAssignProjects={() => {
-              setActiveTab('assignments')
-              setTimeout(() => setPreviewSheetOpen(true), 100)
-            }}
-          />
         </TabsContent>
 
         {/* ═══════════ FILTERING TAB ═══════════ */}

src/app/(applicant)/applicant/team/page.tsx

@@ -357,15 +357,33 @@ export default function ApplicantProjectPage() {
             )}
           </div>
 
-          {/* Mentor info — TODO(PR8 Task 7): list ALL assigned mentors */}
-          {project.mentorAssignments?.[0]?.mentor && (
-            <div className="rounded-lg border p-3 bg-muted/50">
-              <p className="text-sm font-medium mb-1">Assigned Mentor</p>
-              <p className="text-sm text-muted-foreground">
-                {project.mentorAssignments[0].mentor.name} ({project.mentorAssignments[0].mentor.email})
-              </p>
-            </div>
-          )}
+          {(() => {
+            type MentorAssignment = {
+              droppedAt: Date | string | null
+              mentor: { name: string | null; email: string } | null
+            }
+            const active = (
+              (project.mentorAssignments as MentorAssignment[] | undefined) ?? []
+            ).filter((a) => !a.droppedAt && a.mentor)
+            if (active.length === 0) return null
+            return (
+              <div className="rounded-lg border p-3 bg-muted/50">
+                <p className="text-sm font-medium mb-1">
+                  {active.length === 1 ? 'Assigned Mentor' : `Assigned Mentors (${active.length})`}
+                </p>
+                <ul className="space-y-0.5">
+                  {active.map((a, idx) => (
+                    <li key={`${a.mentor!.email}-${idx}`} className="text-sm text-muted-foreground">
+                      {a.mentor!.name ?? a.mentor!.email}
+                      {a.mentor!.name && (
+                        <span className="text-xs"> ({a.mentor!.email})</span>
+                      )}
+                    </li>
+                  ))}
+                </ul>
+              </div>
+            )
+          })()}
 
           {/* Tags */}
           {project.tags && project.tags.length > 0 && (

src/components/admin/round/mentoring-projects-table.tsx

@@ -0,0 +1,229 @@
+'use client'
+
+import { useMemo, useState } from 'react'
+import Link from 'next/link'
+import { trpc } from '@/lib/trpc/client'
+import {
+  Table,
+  TableBody,
+  TableCell,
+  TableHead,
+  TableHeader,
+  TableRow,
+} from '@/components/ui/table'
+import { Badge } from '@/components/ui/badge'
+import { Button } from '@/components/ui/button'
+import { Input } from '@/components/ui/input'
+import { Skeleton } from '@/components/ui/skeleton'
+import { Search, UserPlus, ArrowRight, Sparkles } from 'lucide-react'
+import { CountryDisplay } from '@/components/shared/country-display'
+
+type Filter = 'all' | 'unassigned' | 'assigned' | 'wants_only'
+
+export function MentoringProjectsTable({ roundId }: { roundId: string }) {
+  const [search, setSearch] = useState('')
+  const [filter, setFilter] = useState<Filter>('all')
+
+  const { data, isLoading } = trpc.round.listMentoringProjects.useQuery(
+    { roundId },
+    { refetchInterval: 30_000 },
+  )
+
+  const filtered = useMemo(() => {
+    if (!data) return []
+    const q = search.trim().toLowerCase()
+    return data.projects.filter((p) => {
+      if (filter === 'unassigned' && p.mentors.length > 0) return false
+      if (filter === 'assigned' && p.mentors.length === 0) return false
+      if (filter === 'wants_only' && !p.wantsMentorship) return false
+      if (!q) return true
+      const hay = [
+        p.title,
+        p.teamName ?? '',
+        p.country ?? '',
+        ...p.mentors.map((m) => m.name ?? m.email),
+      ]
+        .join(' ')
+        .toLowerCase()
+      return hay.includes(q)
+    })
+  }, [data, search, filter])
+
+  const totals = useMemo(() => {
+    if (!data)
+      return { total: 0, unassigned: 0, assigned: 0, wants: 0 }
+    return {
+      total: data.projects.length,
+      unassigned: data.projects.filter((p) => p.mentors.length === 0).length,
+      assigned: data.projects.filter((p) => p.mentors.length > 0).length,
+      wants: data.projects.filter((p) => p.wantsMentorship).length,
+    }
+  }, [data])
+
+  if (isLoading) {
+    return (
+      <div className="space-y-2">
+        {[1, 2, 3, 4, 5].map((i) => (
+          <Skeleton key={i} className="h-14 w-full" />
+        ))}
+      </div>
+    )
+  }
+
+  if (!data || data.projects.length === 0) {
+    return (
+      <div className="rounded-md border bg-muted/30 px-4 py-12 text-center text-sm text-muted-foreground">
+        No projects in this mentoring round yet.
+      </div>
+    )
+  }
+
+  const Pill = ({
+    value,
+    label,
+    count,
+  }: {
+    value: Filter
+    label: string
+    count: number
+  }) => (
+    <button
+      type="button"
+      onClick={() => setFilter(value)}
+      className={`rounded-md border px-2.5 py-1 text-xs font-medium transition-colors ${
+        filter === value
+          ? 'border-primary bg-primary text-primary-foreground'
+          : 'bg-background hover:bg-muted'
+      }`}
+    >
+      {label}{' '}
+      <span className="tabular-nums opacity-80">({count})</span>
+    </button>
+  )
+
+  return (
+    <div className="space-y-3">
+      <div className="flex flex-col gap-2 sm:flex-row sm:items-center sm:justify-between">
+        <div className="flex flex-wrap gap-1.5">
+          <Pill value="all" label="All" count={totals.total} />
+          <Pill value="unassigned" label="No mentor" count={totals.unassigned} />
+          <Pill value="assigned" label="Has mentor" count={totals.assigned} />
+          <Pill value="wants_only" label="Wants mentorship" count={totals.wants} />
+        </div>
+        <div className="relative w-full sm:max-w-xs">
+          <Search className="absolute left-2.5 top-1/2 h-3.5 w-3.5 -translate-y-1/2 text-muted-foreground" />
+          <Input
+            value={search}
+            onChange={(e) => setSearch(e.target.value)}
+            placeholder="Search projects, teams, or mentors…"
+            className="pl-8"
+          />
+        </div>
+      </div>
+
+      <div className="overflow-hidden rounded-md border">
+        <Table>
+          <TableHeader>
+            <TableRow>
+              <TableHead>Project</TableHead>
+              <TableHead>Wants?</TableHead>
+              <TableHead>Mentors</TableHead>
+              <TableHead className="w-32 text-right">Action</TableHead>
+            </TableRow>
+          </TableHeader>
+          <TableBody>
+            {filtered.length === 0 ? (
+              <TableRow>
+                <TableCell
+                  colSpan={4}
+                  className="py-8 text-center text-sm text-muted-foreground"
+                >
+                  No projects match the current filter.
+                </TableCell>
+              </TableRow>
+            ) : (
+              filtered.map((p) => (
+                <TableRow key={p.id}>
+                  <TableCell>
+                    <div className="font-medium">{p.title}</div>
+                    <div className="text-xs text-muted-foreground">
+                      {p.teamName ?? '—'}
+                      {p.country && (
+                        <>
+                          {' · '}
+                          <CountryDisplay country={p.country} />
+                        </>
+                      )}
+                    </div>
+                  </TableCell>
+                  <TableCell>
+                    <div className="flex flex-col gap-1">
+                      {p.wantsMentorship ? (
+                        <Badge variant="secondary" className="w-fit text-xs">
+                          Requested
+                        </Badge>
+                      ) : (
+                        <span className="text-xs text-muted-foreground">No</span>
+                      )}
+                      {p.finalistConfirmationStatus !== 'CONFIRMED' && (
+                        <span
+                          className="text-[10px] uppercase tracking-wide text-amber-700"
+                          title="Auto-fill skips projects whose team has not confirmed attendance."
+                        >
+                          {p.finalistConfirmationStatus
+                            ? p.finalistConfirmationStatus.toLowerCase()
+                            : 'no confirmation'}
+                        </span>
+                      )}
+                    </div>
+                  </TableCell>
+                  <TableCell>
+                    {p.mentors.length === 0 ? (
+                      <span className="text-xs italic text-muted-foreground">
+                        Unassigned
+                      </span>
+                    ) : (
+                      <div className="flex flex-wrap gap-1">
+                        {p.mentors.map((m) => (
+                          <Badge
+                            key={m.assignmentId}
+                            variant="outline"
+                            className="gap-1 text-xs"
+                            title={m.email}
+                          >
+                            {(m.method === 'AI_AUTO' ||
+                              m.method === 'AI_SUGGESTED') && (
+                              <Sparkles className="h-3 w-3 text-amber-500" />
+                            )}
+                            {m.name ?? m.email}
+                          </Badge>
+                        ))}
+                      </div>
+                    )}
+                  </TableCell>
+                  <TableCell className="text-right">
+                    <Button asChild size="sm" variant="outline">
+                      <Link href={`/admin/projects/${p.id}/mentor`}>
+                        {p.mentors.length === 0 ? (
+                          <>
+                            <UserPlus className="mr-1 h-3.5 w-3.5" />
+                            Assign
+                          </>
+                        ) : (
+                          <>
+                            Open
+                            <ArrowRight className="ml-1 h-3.5 w-3.5" />
+                          </>
+                        )}
+                      </Link>
+                    </Button>
+                  </TableCell>
+                </TableRow>
+              ))
+            )}
+          </TableBody>
+        </Table>
+      </div>
+    </div>
+  )
+}

src/components/ui/dialog.tsx

@@ -34,7 +34,7 @@ const DialogContent = React.forwardRef<
     <DialogPrimitive.Content
       ref={ref}
       className={cn(
-        'fixed left-[50%] top-[50%] z-50 grid w-full max-w-lg translate-x-[-50%] translate-y-[-50%] gap-4 border bg-background p-6 shadow-lg duration-200 data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 sm:rounded-lg',
+        'fixed left-[50%] top-[50%] z-50 flex max-h-[90vh] w-full max-w-lg translate-x-[-50%] translate-y-[-50%] flex-col gap-4 overflow-y-auto border bg-background p-6 shadow-lg duration-200 data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 sm:rounded-lg',
         className
       )}
       {...props}

src/lib/email.ts

@@ -9,6 +9,12 @@ import { prisma } from '@/lib/prisma'
 const DEV_EMAIL_OVERRIDE = process.env.DEV_EMAIL_OVERRIDE || ''
 
 async function sendEmail(opts: { to: string; subject: string; text: string; html: string }): Promise<void> {
+  // Hard guard: never send real email from the test runner. This is a belt-and-
+  // braces check on top of the vitest-level mock in tests/setup.ts. Vitest sets
+  // NODE_ENV='test' and exposes VITEST=true automatically.
+  if (process.env.NODE_ENV === 'test' || process.env.VITEST === 'true') {
+    return
+  }
   const { transporter, from } = await getTransporter()
   const to = DEV_EMAIL_OVERRIDE || opts.to
   const subject = DEV_EMAIL_OVERRIDE ? `[DEV → ${opts.to}] ${opts.subject}` : opts.subject

src/server/routers/mentor.ts

@@ -818,7 +818,7 @@ export const mentorRouter = router({
         where: {
           roundId: input.roundId,
           project: {
-            mentorAssignments: { none: {} },
+            mentorAssignments: { none: { droppedAt: null } },
             // Only assign mentors to projects whose team has confirmed they will
             // attend the grand finale. This skips PENDING/DECLINED/EXPIRED/SUPERSEDED
             // confirmations and any project without a confirmation row at all.

src/server/routers/round.ts

@@ -227,21 +227,120 @@ export const roundRouter = router({
         where: { id: input.roundId },
         select: { roundType: true, configJson: true },
       })
-      if (round.roundType !== 'MENTORING') return { count: 0 }
+      if (round.roundType !== 'MENTORING') {
+        return { count: 0, eligibleTotal: 0, mentorPoolSize: 0 }
+      }
       const config = (round.configJson ?? {}) as Record<string, unknown>
       const eligibility = (config.eligibility as string) ?? 'requested_only'
-      if (eligibility === 'admin_selected') return { count: 0 }
+      if (eligibility === 'admin_selected') {
+        return { count: 0, eligibleTotal: 0, mentorPoolSize: 0 }
+      }
 
-      const count = await ctx.prisma.projectRoundState.count({
-        where: {
-          roundId: input.roundId,
+      const eligibilityWhere =
+        eligibility === 'requested_only' ? { wantsMentorship: true } : {}
+
+      // Mirror autoAssignBulkForRound's filter exactly so the toolbar count
+      // matches what the auto-fill button will actually process.
+      const autoFillWhere = {
+        mentorAssignments: { none: { droppedAt: null } },
+        finalistConfirmation: { status: 'CONFIRMED' as const },
+        ...eligibilityWhere,
+      }
+      const [count, eligibleTotal, mentorPoolSize] = await Promise.all([
+        ctx.prisma.projectRoundState.count({
+          where: { roundId: input.roundId, project: autoFillWhere },
+        }),
+        ctx.prisma.projectRoundState.count({
+          where: {
+            roundId: input.roundId,
+            project: {
+              finalistConfirmation: { status: 'CONFIRMED' as const },
+              ...eligibilityWhere,
+            },
+          },
+        }),
+        ctx.prisma.user.count({
+          where: { roles: { has: 'MENTOR' }, status: { not: 'SUSPENDED' } },
+        }),
+      ])
+      return { count, eligibleTotal, mentorPoolSize }
+    }),
+
+  /**
+   * List projects in a MENTORING round with their (multi-)mentor assignments.
+   * Drives the per-team assignment table on the round Projects tab so admins
+   * can see who is assigned to whom and add/swap mentors per project.
+   */
+  listMentoringProjects: adminProcedure
+    .input(z.object({ roundId: z.string() }))
+    .query(async ({ ctx, input }) => {
+      const round = await ctx.prisma.round.findUniqueOrThrow({
+        where: { id: input.roundId },
+        select: { roundType: true, configJson: true },
+      })
+      if (round.roundType !== 'MENTORING') return { projects: [] }
+
+      const config = (round.configJson ?? {}) as Record<string, unknown>
+      const eligibility = (config.eligibility as string) ?? 'requested_only'
+
+      const states = await ctx.prisma.projectRoundState.findMany({
+        where: { roundId: input.roundId },
+        select: {
+          state: true,
           project: {
-            mentorAssignments: { none: {} },
-            ...(eligibility === 'requested_only' ? { wantsMentorship: true } : {}),
+            select: {
+              id: true,
+              title: true,
+              teamName: true,
+              country: true,
+              wantsMentorship: true,
+              competitionCategory: true,
+              finalistConfirmation: { select: { status: true } },
+              mentorAssignments: {
+                where: { droppedAt: null },
+                select: {
+                  id: true,
+                  method: true,
+                  assignedAt: true,
+                  mentor: { select: { id: true, name: true, email: true } },
+                },
+                orderBy: { assignedAt: 'asc' },
+              },
+            },
           },
         },
+        orderBy: [{ project: { title: 'asc' } }],
       })
-      return { count }
+
+      return {
+        eligibility,
+        projects: states.map((s) => {
+          const isEligible =
+            eligibility === 'all_in_round' ||
+            eligibility === 'admin_selected' ||
+            s.project.wantsMentorship
+          return {
+            id: s.project.id,
+            title: s.project.title,
+            teamName: s.project.teamName,
+            country: s.project.country,
+            competitionCategory: s.project.competitionCategory,
+            wantsMentorship: s.project.wantsMentorship,
+            finalistConfirmationStatus:
+              s.project.finalistConfirmation?.status ?? null,
+            isEligible,
+            state: s.state,
+            mentors: s.project.mentorAssignments.map((a) => ({
+              assignmentId: a.id,
+              method: a.method,
+              assignedAt: a.assignedAt,
+              id: a.mentor.id,
+              name: a.mentor.name,
+              email: a.mentor.email,
+            })),
+          }
+        }),
+      }
     }),
 
   /**