Files

Matt 16156111a6 feat: complete MENTORING round config form (§A)

Surfaces every MentoringConfigSchema field on the round Config tab:

- Adds "Mentoring Request Window" card with mentoringRequestDeadlineDays
  numeric input (1-90 days, default 14) and passThroughIfNoRequest toggle
  (default ON; OFF holds projects PENDING until manual mentor assignment).
- Adds inline help-text for the Eligibility dropdown explaining each
  option's effect on auto-PASS behavior.
- Hides the General Settings card on MENTORING rounds (it only renders
  Advancement Targets, which don't apply to a pass-through round).
- Relaxes the Launch Readiness "File requirements set" gate for MENTORING
  rounds without filePromotionEnabled + a target window — file requirements
  only matter when files will be promoted to a downstream submission window.

Spec: docs/superpowers/specs/2026-04-28-mentor-round-readiness-design.md §A
Plan: docs/superpowers/plans/2026-04-28-pr3-mentoring-config-completeness.md

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-04-28 14:25:23 +02:00

1.9 KiB

Raw Blame History

PR 3 — MENTORING Round Config Completeness (§A)

For agentic workers: Use superpowers:executing-plans for inline execution.

Goal: Surface every MentoringConfigSchema field on the round Config tab; hide the empty General Settings card on MENTORING rounds; relax the "File requirements set" Launch Readiness gate when no file promotion is configured.

Architecture: UI-only changes. No schema, no API. Three files touched.

Spec: docs/superpowers/specs/2026-04-28-mentor-round-readiness-design.md §A.

File map

File	Action	Why
`src/components/admin/rounds/config/mentoring-config.tsx`	Modify	Add `mentoringRequestDeadlineDays` numeric input + `passThroughIfNoRequest` toggle; add help-text to Eligibility
`src/app/(admin)/admin/rounds/[roundId]/page.tsx`	Modify	Hide General Settings card when `round.roundType === 'MENTORING'`; relax File-requirements readiness gate for MENTORING rounds without file promotion configured

Tasks

Task 1: Add the two missing inputs to `mentoring-config.tsx`

Step 1: Patch the file — append a new "Mentoring Request Window" card BETWEEN the existing two cards, and add help-text to Eligibility. Code in execution.
Step 2: Typecheck — npm run typecheck. Expect 0 errors.

Task 2: Hide General Settings card + relax readiness on MENTORING rounds

Step 1: Patch (admin)/admin/rounds/[roundId]/page.tsx — wrap the General Settings card in {!isMentoring && (...)} and extend the file-requirements bypass condition.
Step 2: Typecheck + build — confirm clean.

Task 3: Smoke + commit

Step 1: npm run build — confirm clean.
Step 2: Commit — message references §A.

Out of scope

Form unit tests (heavy render setup; existing config-save mutation already verified by other PRs). Manual smoke covers the UI work.

1.9 KiB Raw Blame History