fix: compute z-context per-round in edition-mode rankings rollup
Previously the edition-level branch of analytics.getProjectRankings (programId mode) pooled every juror's evaluations across every round into a single z-normalization context. A juror's mean and stddev are not stable across round types — quick intake screening produces a very different grading profile than a deep evaluation round, and mixing them yields a meaningless personal calibration. The rollup now groups points by roundId, computes one balance context per round, and aggregates per-project as the unweighted mean of the per-round balanced averages. roundId mode is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -6,7 +6,13 @@ import { getProjectLogoUrl } from '../utils/project-logo-url'
|
||||
import { aggregateVotes } from '../services/deliberation'
|
||||
import { validateRoundConfig } from '@/types/competition-configs'
|
||||
import type { LiveFinalConfig } from '@/types/competition-configs'
|
||||
import { computeBalanceContext, computeBalancedProjectScores, type ScorePoint } from '../services/juror-balance'
|
||||
import {
|
||||
computeBalanceContext,
|
||||
computeBalancedProjectScores,
|
||||
computePerRoundBalanced,
|
||||
type ScorePoint,
|
||||
type RoundScopedScorePoint,
|
||||
} from '../services/juror-balance'
|
||||
import { generateJurorCalibration } from '../services/ai-juror-calibration'
|
||||
|
||||
const editionOrRoundInput = z.object({
|
||||
@@ -213,24 +219,39 @@ export const analyticsRouter = router({
|
||||
where: evalWhere(input, { status: 'SUBMITTED' }),
|
||||
select: {
|
||||
criterionScoresJson: true,
|
||||
assignment: { select: { userId: true, projectId: true } },
|
||||
assignment: { select: { userId: true, projectId: true, roundId: true } },
|
||||
},
|
||||
}),
|
||||
])
|
||||
|
||||
// Extract a single eval-level score (mean of numeric criterion scores) per evaluation.
|
||||
const points: ScorePoint[] = []
|
||||
const rawPoints: RoundScopedScorePoint[] = []
|
||||
for (const e of evaluations) {
|
||||
const scores = e.criterionScoresJson as Record<string, unknown> | null
|
||||
if (!scores) continue
|
||||
const vals = Object.values(scores).filter((s): s is number => typeof s === 'number')
|
||||
if (vals.length === 0) continue
|
||||
const rawScore = vals.reduce((a, b) => a + b, 0) / vals.length
|
||||
points.push({ projectId: e.assignment.projectId, userId: e.assignment.userId, rawScore })
|
||||
rawPoints.push({
|
||||
projectId: e.assignment.projectId,
|
||||
userId: e.assignment.userId,
|
||||
roundId: e.assignment.roundId,
|
||||
rawScore,
|
||||
})
|
||||
}
|
||||
|
||||
const balanceCtx = computeBalanceContext(points)
|
||||
const balancedByProject = computeBalancedProjectScores(points, balanceCtx)
|
||||
// roundId mode: single-round z-context (existing behavior).
|
||||
// programId mode: per-round z-contexts aggregated as the mean of per-round
|
||||
// balanced averages — never pool z-contexts across rounds because a juror's
|
||||
// grading profile differs by round type.
|
||||
const balancedByProject: Map<string, { rawAverage: number | null; balancedAverage: number | null; count: number }> = (() => {
|
||||
if (input.roundId) {
|
||||
const flat: ScorePoint[] = rawPoints.map(({ projectId, userId, rawScore }) => ({ projectId, userId, rawScore }))
|
||||
const ctx = computeBalanceContext(flat)
|
||||
return computeBalancedProjectScores(flat, ctx)
|
||||
}
|
||||
return computePerRoundBalanced(rawPoints)
|
||||
})()
|
||||
|
||||
const rankings = projects
|
||||
.map((project) => {
|
||||
|
||||
@@ -118,3 +118,71 @@ export function computeBalancedProjectScores(
|
||||
|
||||
return results
|
||||
}
|
||||
|
||||
/**
|
||||
* Per-round balanced rollup: groups points by roundId, computes a balance
|
||||
* context per round, then averages the per-round balanced averages for each
|
||||
* project. Use when surfacing edition-level rankings — never pool z-contexts
|
||||
* across rounds, because a juror's grading profile differs by round type.
|
||||
*/
|
||||
export type RoundScopedScorePoint = ScorePoint & { roundId: string }
|
||||
|
||||
export type EditionRollupResult = {
|
||||
projectId: string
|
||||
rawAverage: number | null
|
||||
balancedAverage: number | null
|
||||
count: number
|
||||
roundCount: number
|
||||
}
|
||||
|
||||
export function computePerRoundBalanced(
|
||||
points: RoundScopedScorePoint[],
|
||||
): Map<string, EditionRollupResult> {
|
||||
const byRound = new Map<string, ScorePoint[]>()
|
||||
for (const p of points) {
|
||||
const arr = byRound.get(p.roundId) ?? []
|
||||
arr.push({ projectId: p.projectId, userId: p.userId, rawScore: p.rawScore })
|
||||
byRound.set(p.roundId, arr)
|
||||
}
|
||||
|
||||
const perRoundResults: Array<Map<string, BalancedProjectResult>> = []
|
||||
for (const roundPoints of byRound.values()) {
|
||||
const ctx = computeBalanceContext(roundPoints)
|
||||
perRoundResults.push(computeBalancedProjectScores(roundPoints, ctx))
|
||||
}
|
||||
|
||||
const accumulator = new Map<
|
||||
string,
|
||||
{ rawSum: number; rawCount: number; balancedSum: number; balancedCount: number; count: number; roundCount: number }
|
||||
>()
|
||||
for (const roundMap of perRoundResults) {
|
||||
for (const [projectId, result] of roundMap.entries()) {
|
||||
const acc = accumulator.get(projectId) ?? {
|
||||
rawSum: 0, rawCount: 0, balancedSum: 0, balancedCount: 0, count: 0, roundCount: 0,
|
||||
}
|
||||
if (result.rawAverage != null) {
|
||||
acc.rawSum += result.rawAverage
|
||||
acc.rawCount += 1
|
||||
}
|
||||
if (result.balancedAverage != null) {
|
||||
acc.balancedSum += result.balancedAverage
|
||||
acc.balancedCount += 1
|
||||
}
|
||||
acc.count += result.count
|
||||
acc.roundCount += 1
|
||||
accumulator.set(projectId, acc)
|
||||
}
|
||||
}
|
||||
|
||||
const out = new Map<string, EditionRollupResult>()
|
||||
for (const [projectId, acc] of accumulator.entries()) {
|
||||
out.set(projectId, {
|
||||
projectId,
|
||||
rawAverage: acc.rawCount > 0 ? acc.rawSum / acc.rawCount : null,
|
||||
balancedAverage: acc.balancedCount > 0 ? acc.balancedSum / acc.balancedCount : null,
|
||||
count: acc.count,
|
||||
roundCount: acc.roundCount,
|
||||
})
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user