fix(lunch): reminder filter, recap failure surfacing, manual send-reminders

- Extract selectUnpickedAttendees helper with OR filter (is null OR pickedAt null)
  to fix cron missing attendees with no MemberLunchPick row at all
- Update cron route to use the helper
- sendRecap now throws TRPCError on email failure instead of silently stamping success
- Add lunch.sendReminders adminProcedure for manual on-demand reminder sends
- Add "Send reminders now" AlertDialog button to LunchRecapActions
- Tests: lunch-reminder-filter.test.ts (2 new), all 5 lunch test files pass (40 tests)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt
2026-06-04 16:24:01 +02:00
parent 884c96c710
commit 3f25ba112b
6 changed files with 269 additions and 13 deletions

View File

@@ -0,0 +1,32 @@
import type { PrismaClient } from '@prisma/client'
/**
* Return all AttendingMember rows (with user) that:
* - belong to a CONFIRMED FinalistConfirmation in the given program
* - have NOT yet picked a lunch dish (no MemberLunchPick row OR pick row with pickedAt=null)
*
* This is extracted from the cron so it can be unit-tested independently and
* reused by the manual `sendReminders` admin action.
*
* Bug context: Prisma `lunchPick: { is: { pickedAt: null } }` only matches rows
* that EXIST but have pickedAt=null. Attendees with no pick row at all fall
* through. The correct filter is the OR form below.
*/
export async function selectUnpickedAttendees(
prisma: PrismaClient,
event: { id: string; programId: string },
) {
return prisma.attendingMember.findMany({
where: {
confirmation: {
project: { programId: event.programId },
status: 'CONFIRMED',
},
OR: [
{ lunchPick: { is: null } },
{ lunchPick: { is: { pickedAt: null } } },
],
},
include: { user: { select: { name: true, email: true } } },
})
}