Platform review round 2: audit logging migration, nav unification, DB indexes, and UI polish

- Migrate ~41 inline audit log calls to shared logAudit() utility across all routers
- Add transaction-aware prisma parameter to logAudit() for atomic operations
- Unify jury/mentor/observer navigation into shared RoleNav component
- Add composite DB indexes (Evaluation, GracePeriod, AuditLog) for query performance
- Fix profile page: consolidate dual save buttons, proper useEffect initialization
- Enhance auth error page with MOPC branding and navigation
- Improve observer dashboard with prominent read-only badge
- Fix DI-3: fetch projects before bulk status update for accurate notifications
- Remove unused aiBoost field from smart-assignment scoring
- Add shared image-upload utility and structured logger module

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

src/server/routers/settings.ts

@@ -4,6 +4,7 @@ import { getWhatsAppProvider, getWhatsAppProviderType } from '@/lib/whatsapp'
 import { listAvailableModels, testOpenAIConnection, isReasoningModel } from '@/lib/openai'
 import { getAIUsageStats, getCurrentMonthCost, formatCost } from '@/server/utils/ai-usage'
 import { clearStorageProviderCache } from '@/lib/storage'
+import { logAudit } from '../utils/audit'
 
 /**
  * Categorize an OpenAI model for display
@@ -124,19 +125,18 @@ export const settingsRouter = router({
       }
 
       // Audit log (don't log actual value for secrets)
-      await ctx.prisma.auditLog.create({
-        data: {
-          userId: ctx.user.id,
-          action: 'UPDATE_SETTING',
-          entityType: 'SystemSettings',
-          entityId: setting.id,
-          detailsJson: {
-            key: input.key,
-            isSecret: setting.isSecret,
-          },
-          ipAddress: ctx.ip,
-          userAgent: ctx.userAgent,
+      await logAudit({
+        prisma: ctx.prisma,
+        userId: ctx.user.id,
+        action: 'UPDATE_SETTING',
+        entityType: 'SystemSettings',
+        entityId: setting.id,
+        detailsJson: {
+          key: input.key,
+          isSecret: setting.isSecret,
         },
+        ipAddress: ctx.ip,
+        userAgent: ctx.userAgent,
       })
 
       return setting
@@ -193,15 +193,14 @@ export const settingsRouter = router({
       }
 
       // Audit log
-      await ctx.prisma.auditLog.create({
-        data: {
-          userId: ctx.user.id,
-          action: 'UPDATE_SETTINGS_BATCH',
-          entityType: 'SystemSettings',
-          detailsJson: { keys: input.settings.map((s) => s.key) },
-          ipAddress: ctx.ip,
-          userAgent: ctx.userAgent,
-        },
+      await logAudit({
+        prisma: ctx.prisma,
+        userId: ctx.user.id,
+        action: 'UPDATE_SETTINGS_BATCH',
+        entityType: 'SystemSettings',
+        detailsJson: { keys: input.settings.map((s) => s.key) },
+        ipAddress: ctx.ip,
+        userAgent: ctx.userAgent,
       })
 
       return results
@@ -357,19 +356,18 @@ export const settingsRouter = router({
       })
 
       // Audit log
-      await ctx.prisma.auditLog.create({
-        data: {
-          userId: ctx.user.id,
-          action: 'UPDATE_NOTIFICATION_PREFERENCES',
-          entityType: 'User',
-          entityId: ctx.user.id,
-          detailsJson: {
-            notificationPreference: input.notificationPreference,
-            whatsappOptIn: input.whatsappOptIn,
-          },
-          ipAddress: ctx.ip,
-          userAgent: ctx.userAgent,
+      await logAudit({
+        prisma: ctx.prisma,
+        userId: ctx.user.id,
+        action: 'UPDATE_NOTIFICATION_PREFERENCES',
+        entityType: 'User',
+        entityId: ctx.user.id,
+        detailsJson: {
+          notificationPreference: input.notificationPreference,
+          whatsappOptIn: input.whatsappOptIn,
         },
+        ipAddress: ctx.ip,
+        userAgent: ctx.userAgent,
       })
 
       return user