Platform review round 2: audit logging migration, nav unification, DB indexes, and UI polish

- Migrate ~41 inline audit log calls to shared logAudit() utility across all routers
- Add transaction-aware prisma parameter to logAudit() for atomic operations
- Unify jury/mentor/observer navigation into shared RoleNav component
- Add composite DB indexes (Evaluation, GracePeriod, AuditLog) for query performance
- Fix profile page: consolidate dual save buttons, proper useEffect initialization
- Enhance auth error page with MOPC branding and navigation
- Improve observer dashboard with prominent read-only badge
- Fix DI-3: fetch projects before bulk status update for accurate notifications
- Remove unused aiBoost field from smart-assignment scoring
- Add shared image-upload utility and structured logger module

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

src/server/routers/file.ts

@@ -2,6 +2,7 @@ import { z } from 'zod'
 import { TRPCError } from '@trpc/server'
 import { router, protectedProcedure, adminProcedure } from '../trpc'
 import { getPresignedUrl, generateObjectKey, deleteObject, BUCKET_NAME } from '@/lib/minio'
+import { logAudit } from '../utils/audit'
 
 export const fileRouter = router({
   /**
@@ -55,16 +56,15 @@ export const fileRouter = router({
       const url = await getPresignedUrl(input.bucket, input.objectKey, 'GET', 900) // 15 min
 
       // Log file access
-      await ctx.prisma.auditLog.create({
-        data: {
-          userId: ctx.user.id,
-          action: 'FILE_DOWNLOADED',
-          entityType: 'ProjectFile',
-          detailsJson: { bucket: input.bucket, objectKey: input.objectKey },
-          ipAddress: ctx.ip,
-          userAgent: ctx.userAgent,
-        },
-      }).catch(() => {})
+      await logAudit({
+        prisma: ctx.prisma,
+        userId: ctx.user.id,
+        action: 'FILE_DOWNLOADED',
+        entityType: 'ProjectFile',
+        detailsJson: { bucket: input.bucket, objectKey: input.objectKey },
+        ipAddress: ctx.ip,
+        userAgent: ctx.userAgent,
+      })
 
       return { url }
     }),
@@ -112,20 +112,19 @@ export const fileRouter = router({
       })
 
       // Audit log
-      await ctx.prisma.auditLog.create({
-        data: {
-          userId: ctx.user.id,
-          action: 'UPLOAD_FILE',
-          entityType: 'ProjectFile',
-          entityId: file.id,
-          detailsJson: {
-            projectId: input.projectId,
-            fileName: input.fileName,
-            fileType: input.fileType,
-          },
-          ipAddress: ctx.ip,
-          userAgent: ctx.userAgent,
+      await logAudit({
+        prisma: ctx.prisma,
+        userId: ctx.user.id,
+        action: 'UPLOAD_FILE',
+        entityType: 'ProjectFile',
+        entityId: file.id,
+        detailsJson: {
+          projectId: input.projectId,
+          fileName: input.fileName,
+          fileType: input.fileType,
         },
+        ipAddress: ctx.ip,
+        userAgent: ctx.userAgent,
       })
 
       return {
@@ -167,20 +166,19 @@ export const fileRouter = router({
       }
 
       // Audit log
-      await ctx.prisma.auditLog.create({
-        data: {
-          userId: ctx.user.id,
-          action: 'DELETE_FILE',
-          entityType: 'ProjectFile',
-          entityId: input.id,
-          detailsJson: {
-            fileName: file.fileName,
-            bucket: file.bucket,
-            objectKey: file.objectKey,
-          },
-          ipAddress: ctx.ip,
-          userAgent: ctx.userAgent,
+      await logAudit({
+        prisma: ctx.prisma,
+        userId: ctx.user.id,
+        action: 'DELETE_FILE',
+        entityType: 'ProjectFile',
+        entityId: input.id,
+        detailsJson: {
+          fileName: file.fileName,
+          bucket: file.bucket,
+          objectKey: file.objectKey,
         },
+        ipAddress: ctx.ip,
+        userAgent: ctx.userAgent,
       })
 
       return file